search

SigNoz / signoz-otel-collector

SigNoz distro for OpenTelemetry Collector
44 stars 39 forks source link

feat: add instrumentation scope support #336

Closed nityanandagohain closed 2 months ago

nityanandagohain commented 2 months ago

Otel collector changes for https://github.com/SigNoz/signoz/issues/2705

srikanthccv commented 2 months ago

It also has attributes https://github.com/open-telemetry/opentelemetry-proto/blob/bd7cf55b6d45f3c587d2131b68a7e5a501bdb10c/opentelemetry/proto/common/v1/common.proto#L69-L81; Do we not want to support them for now?

nityanandagohain commented 2 months ago

I was planning to just introduce the name first, but I guess it's better to introduce the version as well.

Let me make the changes.

For instrumentation scope attribute do you think it's better to make changes now ?

srikanthccv commented 2 months ago

I suggest adding the attributes as well so you don't have to come back to it again in future if somebody asks for it.

nityanandagohain commented 2 months ago

hmm makes sense, regarding the implementation of it do see any cons with storing the attributes in a similar way to that of resource attributes. Here will we will name it as instrumentation_scope_string_key, instrumentation_scope_string_value.

srikanthccv commented 2 months ago

I don't see any issue.

nityanandagohain commented 2 months ago

have added support for name, version and attributes.