SigNoz / signoz-otel-collector

SigNoz distro for OpenTelemetry Collector
44 stars 39 forks source link

Skip write to time_series_v4 table for the same fingerprint in curren… #355

Closed srikanthccv closed 1 month ago

srikanthccv commented 1 month ago

…t hour

Resubmission of https://github.com/SigNoz/signoz-otel-collector/pull/335

The previous version of the change considered only fingerprint but not time. It fails when the entry is added at the current hour :15 minutes. This resubmission includes the unixmilli as part of cache key. This will ensure there will be one fingerprint inserted if the hour changes.

nityanandagohain commented 1 month ago

@srikanthccv the code changes are the same, please add a description on why it was reverted and how we have fixed the issue because of which it's added back.

srikanthccv commented 1 month ago

Updated!