search

SigNoz / signoz

SigNoz is an open-source observability platform native to OpenTelemetry with logs, traces and metrics in a single application. An open-source alternative to DataDog, NewRelic, etc. 🔥 🖥. 👉 Open source Application Performance Monitoring (APM) & Observability tool
https://signoz.io
Other
19.18k stars 1.27k forks source link

[EPIC] Dashboard improvements #3573

Open ankitnayan opened 1 year ago

ankitnayan commented 1 year ago

Frontend

Enhancements

Miscellaneous

srikanthccv commented 1 year ago

Should the backend throw an error if any update call from frontend tries to wipe out the layout or widgets from the payload? Can we assume any update from the client can only remove a maximum of one panel and throw an error otherwise? Ideally, the bug that causes this should be fixed. Meanwhile, preventing the destruction action seems like a better thing to do. It's a very poor experience and frustrating to see the whole dashboard disappear from end-user POV.

ankitnayan commented 1 year ago

client can only remove a maximum of one panel

this can be too restrictive. The issue seems to wipe out the dashboard. Should we enable a backend check of wiping all panels till we are able to reproduce?

srikanthccv commented 1 year ago

I don't think it's restrictive. Is there a way one can remove multiple panels at the same time (i.e. in the same request) today?

ankitnayan commented 1 year ago

hmm. I don't think it can be done today. We can implement it then. We can create an issue to remove this later.

makeavish commented 1 year ago

@palashgdev Please close issues which are merged already.

makeavish commented 1 year ago

Can we also fix https://github.com/SigNoz/signoz/issues/3736 as part of the improvements?

palashgdev commented 1 year ago

Can we also fix #3736 as part of the improvements?

we don't know the use case as of now I am assuming this is fixed in latest version as there were useEffect not it is not the case

makeavish commented 1 year ago

Can we also fix #3736 as part of the improvements?

we don't know the use case as of now I am assuming this is fixed in latest version as there were useEffect not it is not the case

@srikanthccv Can you confirm if it's fixed in latest version? Can we close the issue?

srikanthccv commented 1 year ago

We don't know how to reproduce the issue to test if it is fixed or not.

srikanthccv commented 1 year ago

@palashgdev, please share the response format you mentioned that works well for clients. For any form of breaking changes it's better we introduce now because we can't do the same after we publish the API response which has growing demand.

srikanthccv commented 1 year ago

we don't know the use case as of now I am assuming this is fixed in latest version as there were useEffect not it is not the case

This is still not fixed based on one of the issues reported by a user. The layout array was wiped out (we had a fix for widgets, but they were still there), and the blank screen was shown. Let's find out and try to fix this on priority.

prashant-shahi commented 1 year ago

@ankitnayan Can this be included as well? https://github.com/SigNoz/signoz/issues/3216

ankitnayan commented 1 year ago

@ankitnayan Can this be included as well? #3216

yes

srikanthccv commented 11 months ago

@palashgdev, please share the response format you mentioned that works well for clients. For any form of breaking changes it's better we introduce now because we can't do the same after we publish the API response which has growing demand.

@palashgdev @YounixM please take some time to work on this so that we can discuss and finalise it. We are going to make some changes to request payload as well.

palashgdev commented 11 months ago

@palashgdev, please share the response format you mentioned that works well for clients. For any form of breaking changes it's better we introduce now because we can't do the same after we publish the API response which has growing demand.

@palashgdev @YounixM please take some time to work on this so that we can discuss and finalise it. We are going to make some changes to request payload as well.

sure @srikanthccv will share

ankitnayan commented 9 months ago
Screenshot 2024-02-01 at 11 37 55 PM Screenshot 2024-02-01 at 11 38 37 PM