SigNoz / signoz

SigNoz is an open-source observability platform native to OpenTelemetry with logs, traces and metrics in a single application. An open-source alternative to DataDog, NewRelic, etc. 🔥 🖥. 👉 Open source Application Performance Monitoring (APM) & Observability tool
https://signoz.io
Other
18.12k stars 1.15k forks source link

Better UI for filter on empty string in query builder #3762

Open makeavish opened 10 months ago

makeavish commented 10 months ago

https://github.com/SigNoz/signoz/issues/3725#issuecomment-1759197459 image

joemiltonm commented 10 months ago

Hi SigNoz team, just need a small clarification. In the search filter, after selecting the operators, is it expected to list options with one of them being empty string with quotes. like in the below snapshot, instead of <component = > the first option has to be

Screenshot from 2023-10-27 00-25-18

makeavish commented 10 months ago

Hi SigNoz team, just need a small clarification. In the search filter, after selecting the operators, is it expected to list options with one of them being empty string with quotes. like in the below snapshot, instead of <component = > the first option has to be

Screenshot from 2023-10-27 00-25-18

Yes @joemiltonm, currently it's expected.

nityanandagohain commented 5 months ago

We should support this

container_name = "continaer_name = asddsad"
container_name = "continaer_name =\"x\" asddsad"
container_name = cotainer name xyz
container_name = "\"continaer_name = asddsad\""

edge case if not enclosed in quotes just escape it container_name = "continaer_name = asddsad will become \"continaer_name = asddsad for api(auto suggested) container_name = "\"continaer_name = asddsad" will become \"continaer_name = asddsad for api (manual)

container_name = hotrot is same as container_name = "hotrot" => value hotrot

container_name = "\"hotrot\"" => value "hotrot" Algo