SigNoz / signoz

SigNoz is an open-source observability platform native to OpenTelemetry with logs, traces and metrics in a single application. An open-source alternative to DataDog, NewRelic, etc. 🔥 🖥. 👉 Open source Application Performance Monitoring (APM) & Observability tool
https://signoz.io
Other
18.11k stars 1.15k forks source link

error message displaying twice if signoz failed to install using install script #5187

Open nitishfy opened 2 months ago

nitishfy commented 2 months ago

Bug description

When you try to self host SigNoz by using the install script, there are chances that you may come across certain errors due to which signoz might not get installed properly. Ideally, the error message should be displayed only once. However, the error message repeats twice.

It looks like the error message is being displayed twice due to the trap bye EXIT statement combined with the conditional checks later in the script.

Please describe.

🟡 Starting the SigNoz containers. It may take a few minutes ...

[+] Running 3/4
 â ¿ Container hotrod              Started                                                                                                                                        0.7s
 â ¿ Container load-hotrod         Started                                                                                                                                        0.5s
 â ¿ Container signoz-zookeeper-1  Started                                                                                                                                        0.7s
 â ¿ Container signoz-clickhouse   Waiting                                                                                                                                        3.8s
container for service "clickhouse" is unhealthy
Waiting for all containers to start. This check will timeout in 1 seconds ....

+++++++++++ ERROR ++++++++++++++++++++++
🔴 The containers didn't seem to start correctly. Please run the following command to check containers that may have errored out:

 docker-compose -f ./docker/clickhouse-setup/docker-compose.yaml ps -a
Please read our troubleshooting guide https://signoz.io/docs/install/troubleshooting/
or reach us on SigNoz for support https://signoz.io/slack
++++++++++++++++++++++++++++++++++++++++
🔴 The containers didn't seem to start correctly. Please run the following command to check containers that may have errored out:

 docker-compose -f ./docker/clickhouse-setup/docker-compose.yaml ps -a
Please read our troubleshooting guide https://signoz.io/docs/install/troubleshooting/
or reach us for support in #help channel in our Slack Community https://signoz.io/slack
++++++++++++++++++++++++++++++++++++++++

Expected behavior

The error message should be displayed only once.

How to reproduce

  1. Follow the instructions mentioned here to self host signoz.
  2. If you come across error container <container-name> is unhealthy, you'll see the error statement printed twice.

Thank you for your bug report – we love squashing them!

welcome[bot] commented 2 months ago

Thanks for opening this issue. A team member should give feedback soon. In the meantime, feel free to check out the contributing guidelines.

nitishfy commented 2 months ago

Personally, I'd like to work on this too.