Open shivanshuraj1333 opened 4 months ago
@shivanshuraj1333 i would love to work on this
@shivanshuraj1333 may i work on this
@Naresh-kumar-Thodupunoori go ahead, it's an easy issue, just try to find all the env variables, and try to standardize them.
@shivanshuraj1333 Can you assign me this
Hey @shivanshuraj1333 Should I have to standardize for every folder in query-service?
Hey @shivanshuraj1333 ,I did like to work on this issue. Wanted to confirm for Standardization do we want to use knoaf library ?
this one is relatively simple, just have all the ENV variables standardised at a place, right now they are scattered among files. for loading the env variables we can keep what we use today. No need of knoaf at the moment
Right now, there's no standard way to configure environment variables for query service, for helm installation, the below ENVs are populated but similarly to running locally the ENVs are not well defined, it should match with the docker counter part.
from a container
but the same is missing for locally running the query service and the parameters are hardcoded in strings eg https://github.com/SigNoz/signoz/blob/develop/pkg/query-service/app/server.go#L113 https://github.com/SigNoz/signoz/blob/develop/pkg/query-service/app/clickhouseReader/reader.go#L146