feat: corrected the handling of relativeTime as null in alertHistory

SigNoz / signoz

SigNoz is an open-source observability platform native to OpenTelemetry with logs, traces and metrics in a single application. An open-source alternative to DataDog, NewRelic, etc. 🔥 🖥. 👉 Open source Application Performance Monitoring (APM) & Observability tool

https://signoz.io

Other

19.47k stars 1.31k forks source link

feat: corrected the handling of relativeTime as null in alertHistory #6392

Closed SagarRajput-7 closed 2 weeks ago

SagarRajput-7 commented 2 weeks ago

Summary

Earlier logic had params.get(QueryParams.relativeTime) returning as null but in string i.e. "null" hence the nullish operator added to handle and assign the defaultRelativeValue was not working as expected.

Corrected that and checked string null separately

Related Issues / PR's

Screenshots

https://github.com/user-attachments/assets/48a6eeb1-96a9-4d3d-97e3-5574320254b0

Affected Areas and Manually Tested Areas

tested current behaviour with relativeTime=null and existing behaviours

github-actions[bot] commented 2 weeks ago

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #

github-actions[bot] commented 2 weeks ago

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #

github-actions[bot] commented 2 weeks ago

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #