search

SigNoz / signoz

SigNoz is an open-source observability platform native to OpenTelemetry with logs, traces and metrics in a single application. An open-source alternative to DataDog, NewRelic, etc. 🔥 🖥. 👉 Open source Application Performance Monitoring (APM) & Observability tool
https://signoz.io
Other
19.43k stars 1.31k forks source link

fix: ignore ts for panel type table #6419

Closed nityanandagohain closed 1 week ago

nityanandagohain commented 1 week ago

Since we don't have ts in table panel, it should not be there in expressions.

[!IMPORTANT] Excludes ts from group tags in queries for table panel types in query_builder.go, with corresponding test updates in query_builder_test.go.

  • Behavior:
    • In query_builder.go, expressionToQuery() now excludes ts from groupTags if PanelType is v3.PanelTypeTable.
  • Tests:
    • Updated query_builder_test.go to reflect changes in expected queries for table panel types, ensuring ts is not included.

This description was created by Ellipsis for 24860596d365a06e069218da213e379fb515a9c0. It will automatically update as commits are pushed.

github-actions[bot] commented 1 week ago

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #

github-actions[bot] commented 1 week ago

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #

srikanthccv commented 1 week ago

Can you help me understand what is the issue that necessitated removing ts?

nityanandagohain commented 1 week ago

@srikanthccv it's because of this https://github.com/SigNoz/signoz/pull/5908#discussion_r1751801692 . We have removed ts from panelTypeTable. Because of which expressions are failing in table panel types as it's trying to select timestamp from the subqueries and ts is not present in those subqueries.