search

Sigfried / supergroup

Supergroup brings extreme convenience and understandability to the manipulation of Javascript data collections, especially in the context of D3.js visualization programming.
http://sigfried.github.io/supergroup/
88 stars 13 forks source link

children/childprops used inconsistently #13

Open Sigfried opened 7 years ago

Sigfried commented 7 years ago

For instance: https://github.com/Sigfried/supergroup/blob/master/supergroup.js#L373 and line 377. Should get rid of both and use a common method, getChildren that returns val[childprop]. Also do same with parent (which will resolve https://github.com/Sigfried/supergroup/issues/5).

Sigfried commented 7 years ago

Added getChildren and hasChildren in https://github.com/Sigfried/supergroup/commit/4749d01d6656ca9667b744475fcebdcfc54cfa29