search

SiggiGue / pyfilterbank

Implementing a fractional octave filterbank for python. Based on Numpy and CFFI.
107 stars 27 forks source link

Add oct_ratio option to specify base-2 system or base-10 system #25

Open peterleif opened 1 year ago

peterleif commented 1 year ago

I added support for base-10 octave ratio to your library. The default behavior is kept to base-2 for backward compatibility. It would be happy if you consider this feature to be merged.

Nitnelav commented 1 year ago

👍 for base 10. I don't know if your filtering implementation includes decimation stages but if so, they'll need to be updated to match the base10 filters.

peterleif commented 1 year ago

👍 for base 10. I don't know if your filtering implementation includes decimation stages but if so, they'll need to be updated to match the base10 filters.

I checked the filtering functions (in sosfiltering.py and sosfilt.c) and they do not include decimation stages. I believe no modification is needed in filtering stage.