search

SighPie / HFM

# Historical Flavour Mod
106 stars 60 forks source link

Province Name Changing Errors #155

Open rderekp opened 5 years ago

rderekp commented 5 years ago

I'm going to figure out how to do a pull request one of these days.

But, on line 2569, in the part about organizing Tanzania, there is this:

      1850 = { change_province_name = "Tabora" }

But province 1850 is a province in Eritrea. I think this should be province 2043. (Which is already called Tabora, but that happens sometimes with the existing code.)

EDIT: I found some more similar duplications.

In decisions/SAF.txt and events/BritishDominions.txt, province 2110 can have its name changed to Hoedspruit. But in events/BoerWar.txt and decisions/BoerWar.txt, it's province 3273 which gets the name change to Hoedspruit. To be honest, I am not exactly sure which is correct, and maybe the creator of the SAF mod knows?

Also, in decisions/FlavourMod_France_Colonial.txt, both provinces 2515 and 2571 are changed to the name "Jeanne" for French New Zealand.