SightstoneOfficial / LegendaryClient

LegendaryClient, rebooted
69 stars 59 forks source link

New design #373

Closed secretdataz closed 8 years ago

secretdataz commented 9 years ago

Material design maybe.

voshond commented 9 years ago

@LegendaryClient/owners i`d like to move the conversation about the Design here.

i`m currently drawing sketches and doing some shops of what it be like. this is the platform of feedback and suggestions. everyone can upload pictures etc and we gonna comment on them, likes dislikes etc so i get a feeling of whats working and whats not.

no 01: the goal here was to organize the homescreen into "cards" so a user could choose which cards of content he displays, order them as he wants, providing quick access to functions and information we could provide right of the homescreen by the "card method". p1 feedback wanted

naeem76 commented 9 years ago

I really like that design mhn23!

eddy5641 commented 9 years ago

I like the multi account idea but using it would be difficult to save all the accounts locally and have them safe

secretdataz commented 9 years ago

I like your card design. +1

NitroXenon commented 9 years ago

It's better than our current homepage :) Awesome +1

voshond commented 9 years ago

https://github.com/LegendaryClient/LegendaryClient/tree/material-design

starting some work, would be nice if someone can confirm: https://github.com/LegendaryClient/LegendaryClient/commit/2f642498f941a5e0d7095273c8d90f61f0700857#commitcomment-11813388

@LegendaryClient/owners

voshond commented 9 years ago

making progress in the branch, looks promising

secretdataz commented 9 years ago

Good work mate

voshond commented 9 years ago

@LegendaryClient/owners what about the Name, i really like Sightstone by now.

and here is the current stage, feedback wanted

PatcherPage patcherpage

LoginPage: loginpage

Warnings: warning

Logo: sightstone_hd

newchild commented 9 years ago

Holy. I really love the material design :O This looks epic!

NitroXenon commented 9 years ago

WoW this is amazing. Like it :+1:

newchild commented 9 years ago

BTW if we are already @new design. I love this champselect design https://www.reddit.com/r/leagueoflegends/comments/3bdngv/champion_select_redesign_work_in_progress/ http://i.imgur.com/Ockb5hl.png Do you think we can do sth similiar? (Maybe a little more in a material-design way, but I like the layout)

secretdataz commented 9 years ago

cough small screens cough

voshond commented 9 years ago

Something breaking in small ones? I testing against 1440:900 as well in 1280:800 and 1920:1080

secretdataz commented 9 years ago

I was talking about @newchild's suggestion. It uses splash art instead of champ icon. Things won't look good on small screens.

Dispersia commented 9 years ago

To be honest, dont care about anything under 1200 resolution. If it's that small, they need to upgrade. We're using latest technologies and technology is getting cheaper, don't make something look bad so it works with smaller resolutions. Also, implement that champ select, that shit is sexy, also, we should contact that guy if he wants to help design.

secretdataz commented 9 years ago

My standard is 1366x768, no smaller.

voshond commented 9 years ago

ok about the screensize, 1200x768 is a viable thing. i try to make the UI as expandable as possible but i agree that i dont want to support 10 year old Computers. if they really want that than i can pick a size and just hardcode it and scale it like the native client does it.

about that Champselect: i dont like it at all. its bulky and they layout is too shabby, i will look into champ select as soon as i'm finished with the Rest of the Things on my Agenda.. a complete UI Rework will takes it time.

aswell i think there is no point of showing how many MasteryPoints your put into an Tree, its usally 21/9 anyway and Labels are indicating things just fine, or the Runes you put in, instead we could make a hover that shows a screen when selecting them but i think that information isnt really necessary

but i promise i will look into an updated version of champ select.

so far here is an image of the Mainpage at the Moment screen

voshond commented 9 years ago

oh yeah and its themeable so far but i havent looked into the thememanager yet, right now have to manually change it in the code, (2 lines in the app.xaml)

capture

voshond commented 9 years ago

okay i admit that thememanager scares me. right now the theme is built on 3 Lines within the App.xaml

here is a List: https://www.google.com/design/spec/style/color.html#color-color-palette

so can someone look into the Branch and update the Theme Manager?

@secretdataz or @Dispersia maybe? :b

eddy5641 commented 9 years ago

For the ui, prepare for multi acc (like a way to select multiple acc's) because i will add that in

voshond commented 9 years ago

@eddy5641 i'm ready when you are

but at the moment i can't really imagine how its exactly be implemented, are we gonna define a default user? i was thinking that we add a dropdown to the upper left corner where the current icon and username is to define the default gateway such as queing, and userinfo displayed on the mainpage

and chat should be connected at all times anyway.

but since i never used wintermint and multiuser never got worked on so far i find it hard to add region contextual stuff when i dont know whereever its actually making sense.

i kind of need a defined idea what the multiuser experience should be like, or you just do it like always, you implement all features and i put them in place. but i prefer when i'm involved in the designprocess in the first place

voshond commented 9 years ago

something like this is UI wise simply added right now: user

voshond commented 9 years ago

FriendList Improvements + RegionLabels: screenshot 2015-07-02 02 51 45

secretdataz commented 9 years ago

Wow this looks pretty.

eddy5641 commented 9 years ago

How i was planning multi-user acc was to have a login page (user and pass on this decrypts the league of legends accs) and they can select the user to login as or to have it automatically log into the main account (user can set this in settings) Basic info like chat status (online, away, invis), username, region and level/rank should be displayed

Some screenshots of wintermint can be found here: http://i.imgur.com/805hwO7.png

voshond commented 9 years ago

okay eddy i will make add an control for the User you can use and a listbox? aswell as i add a Tab to the Settings for Users, adding and selecting the default (basicly the same, not sure how to do an edit, need the code first).

will there be Region Bridging? i'd love to see that.

voshond commented 9 years ago

@eddy5641 how about this?

capture

eddy5641 commented 9 years ago

looks great :+1:

eddy5641 commented 9 years ago

If you rename it, can you change the icon img

voshond commented 9 years ago

Sure i will make a new ico!

Von meinem iPhone gesendet

Am 17.07.2015 um 20:29 schrieb Ed V notifications@github.com:

If you rename it, can you change the icon img

— Reply to this email directly or view it on GitHub.

voshond commented 9 years ago

@Dispersia still have that change for the Theme Manager?

Dispersia commented 9 years ago

Sort of. I was going to wait until he finished the coloring part because there isn't a lot we can do with it at the moment, but if you just want a temp solution I could push it. I kind of want to work on his project a little and get that part sorted, I would love to have a color slider.

voshond commented 9 years ago

@eddy5641 or @secretdataz need help converting some Listviews into Datagrids, right now we use hardcoded controls like LeagueItem,xaml just for viewing simple text.

The Guy from the Material Design Toolkit just updated his Framework to support Datagrids, https://cloud.githubusercontent.com/assets/658107/8911584/57ada726-3485-11e5-8945-29d5d15d3139.gif

i think that in some cases that would remove some stuff that can be done easier maybe.

i have an example in the pluginspage.xaml if you need an datagrid. we just have to define the columns and the rest is added backend.

preferably systemwide

eddy5641 commented 9 years ago

Il try but I currently am set in getting rid or datadragon (rip)

voshond commented 9 years ago

ScreenshotsPage: capture

ScreenshotsOverlay: screenshotsviewer

SkinsPage: skins

voshond commented 9 years ago

ChampSelect: cawwwpture

tell me if this is ok or you want something new i have to admit that champselect is incredibly hard to layout efficient but at the same time keep some visual structure you see in other pages. aswell i am not sure about the width. we need a somewhat fixed width for the Players but then there is not enough space when make it 900px width. i want increase it but 1200 default seems to be a bit high. 1050 would be enough to display everything, feedback wanted ( @secretdataz )

detailed feedback is wanted here, since its on of the most important Pages anyway.

I need Help with the ChampTrade and LockIn Icons, they are there already but the logic didnt make sense to me @NitroXenon @secretdataz @nairaner thats due the change that i dont use img for the icons and using paths instead and just have to change the visibility

secretdataz commented 9 years ago

Increase the width as you wish. Problems I had were involving too much height.

voshond commented 9 years ago

Can you test this layout in a custom botgame with 5 on each

secretdataz commented 9 years ago

image 5th bot on enemy team isn't visible for some reason

edit : although it is visible on coop vs ai for some reason image

eddy5641 commented 9 years ago

I think the chat textbox is a little small. Otherwise it is great

voshond commented 9 years ago

as well as the background is not working there, which almost driven me crazy because i thought it was a bug on my side.

about chat: i can move the timers up where the dodgebutton is and open up that space for us. or i resize the Champions Box to match the height of 3 Summoner controls and let the chat begin at the 5th.

eddy5641 commented 9 years ago

I am going to start some mobile logic

voshond commented 8 years ago

Will do Runes next, Masteries are pretty much done, may just some polishing. Chat edited, Patcher overhauled, Working my way thru the whole Profil and then to the Play Pages.