search

Sigil-Ebook / Sigil

Sigil is a multi-platform EPUB ebook editor
GNU General Public License v3.0
5.96k stars 578 forks source link

[Bug]: Sigil 2.0.2 crashes when embedding fonts #733

Closed Harvey-McArthur closed 1 year ago

Harvey-McArthur commented 1 year ago

Bug Description

I use Sigil to embed fonts in EPUBs. When I updated to 2.0.2, Sigil crashed every time I tried to embed a font. I right-click on the Font folder, click on Add Existing Files, browse for the font files I need, select them, click Open, and after a second or two Sigil closes without doing anyithig with the fonts.

Harvey McArthur

Platform (OS)

Windows (Default)

OS Version / Specifics

Windows 10

What version of Sigil are you using?

2.0.2

Any backtraces or crash reports

No response

kevinhendricks commented 1 year ago

I can not recreate this at all. My guess is your font file has not been properly deobfuscated or is corrupted.

Have you tried with a completely different set of fonts?

Where did you get these fonts from? If from another epub, they may have been either subsetted or obfuscated rendering them unfit for re-use.

What type of font is it?

kevinhendricks commented 1 year ago

If you can provide a link to where we can download these exact fonts, we can test with them to see what the issue is?

dougmassay commented 1 year ago

just added the first two ttf fonts I came across to an epub with 2.0.2 on Windows 10 with no problems.

kevinhendricks commented 1 year ago

So we are going to need more information about the font files so that we can try to recreate this.

dougmassay commented 1 year ago

We're definitely missing some piece of the puzzle. I've tried adding bunch of different font files using both epub2 and epub3, while having different resource types (html, css, opf, image) open in CV.

With nothing else to go on; eliminating third-party antivirus interference would be my first suggestion.

dougmassay commented 1 year ago

The crash should also leave some residue in the Event Viewer. Such entries aren't typically very enlightening, but they might offer a bit of a clue.

kevinhendricks commented 1 year ago

@dougmassay, Perhaps given neither of us can recreate this issue, we should close this issue until the asked for information on the fonts is provided? Or we could leave it open and wait a bit longer. It is your call.

dougmassay commented 1 year ago

I'll wait a bit longer, but I agree. If there's no further info soon, I'll close the issue until more IS provided.

dougmassay commented 1 year ago

Feel free to reopen this issue when, or if, any more info is provided to help us recreate the issue.

Harvey-McArthur commented 1 year ago

Dear Doug,

My apologies, I have only just seen your emails about the font issue with Sigil. We are using Atkinson Hyperlegible, and have been embedding it in our EPUB3 files using Sigil for two years with no problem. This is a set of fonts the Braille Institute has developed. Now every one of our volunteers who has upgraded to the new Sigil versions has had this problem.

Harvey McArthur

From: Doug Massay @.> Sent: Thursday, November 2, 2023 6:49 PM To: Sigil-Ebook/Sigil @.> Cc: Harvey-McArthur @.>; Author @.> Subject: Re: [Sigil-Ebook/Sigil] [Bug]: Sigil 2.0.2 crashes when embedding fonts (Issue #733)

Closed #733https://github.com/Sigil-Ebook/Sigil/issues/733 as completed.

— Reply to this email directly, view it on GitHubhttps://github.com/Sigil-Ebook/Sigil/issues/733#event-10850164923, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASVFQ2VYPPVTSDDVN5JBM5LYCQWPBAVCNFSM6AAAAAA6YLZ2AGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHA2TAMJWGQ4TEMY. You are receiving this because you authored the thread.Message ID: @.***>

kevinhendricks commented 1 year ago

So this issue is tied to a specific font.

Is it freely available? Can you provide a link where we can download the font?

Are you absolutely sure that font file has not been corrupted?

dougmassay commented 1 year ago

You mention the upgrade to Sigil v2.0.2 as when the problem began, but what version of Sigil was everyone upgrading from? 2.0.1? 2.0.0? 1.9.30?

kevinhendricks commented 1 year ago

A Google search provided a link to those fonts and I downloaded them. I was able to easily use Add Existing by right clicking on the Font folder and navigating and selecting those .otf files. I was also able to double click on each of them in BookBrowser and see a sample of each of the fonts. All with no issues at all. But this was with macOS.

I will try with Linux next just in case the issue happens there.

So whatever the issue is, it does not happen on macOS.

For the record the link I used is here:

https://brailleinstitute.org/freefont

kevinhendricks commented 1 year ago

Tried with Manjaro Linux and those fonts and all worked just fine. So whatever the issue is, it seems to be specific to Windows unfortunately.

kevinhendricks commented 1 year ago

What is funny is that you said it crashed after selecting them with Add Existing .. and hitting Open. All that happens after that is the font files are copied to the default folder for Fonts. No font data is actually loaded into memory and used at that point.

I can understand crashes that happen when the embedded font is actually used in a BookBrowser Tab or when the proper css is added and Preview tries to load and use the font data. Crashing does not make much sense when just copying the file and setting up a Resource to point to it.

Very strange.

Are you sure you do not have third party antivirus software running that is causing the problem?

dougmassay commented 1 year ago

No crashes importing them (from the link Kevin provided for Atkinson Hyperlegible) on Windows 10 with Sigil v2.02. I tried the .otf, the .ttf, the .woff and .woff2 versions. Preview works for them all.

I'm right-clicking on the font folder and selecting Add Existing, as mentioned in the original report.

dougmassay commented 1 year ago

Are they being added from a network drive/share by chance?

kevinhendricks commented 1 year ago

And where exactly are you downloading those specific fonts from? An exact URL please.

I have found the original source (see link I provided earlier) and now a different google font source:

https://github.com/googlefonts/atkinson-hyperlegible

Plus a few others. I also found an npm source. But the last time any of those fonts were modified was 2 years ago.

I did find one place that was still editing and adding glyphs to a version of those fonts ...

https://github.com/jacobxperez/atkinson-hyperlegible-pro

So which url should we be downloading font files from to recreate your issue?

Have you tried downloading fresh copies of the fonts directly from the Braille Institute website and testing to see if that changes anything?

kevinhendricks commented 1 year ago

I have now tested the google font versions and the jacobperez pro font versions with Sigil on macOS with no problems.

This sounds more and more like the problem is caused by:

@Harvey-McArthur We really need you to answer our remaining questions so we have some chance of tracking this one down.

Thanks

kevinhendricks commented 1 year ago

Here we go again. This is still an incomplete report of a "bug" that nether one of us can recreate.

So feel free to close this again anytime you want and we can reopen this if and when the bug reporter actually provides more information and sticks around long enough to actually answer our questions.

kevinhendricks commented 1 year ago

Closing this as not a Sigil bug until the bug reporter actually sticks around long enough to answer questions to prove otherwise and help.