search

Sigil-Ebook / Sigil

Sigil is a multi-platform EPUB ebook editor
GNU General Public License v3.0
5.97k stars 578 forks source link

New Lines in Messages #771

Closed BeckyDTP closed 2 months ago

BeckyDTP commented 2 months ago

Since the \n character did not create a new line in the messages, I added <br> in three places. This works well. Below is the before and after view.

Message One: sigil-no-valid-spine-before sigil-no-valid-spine-after

Message Two: sigil-no-identify-ncx-before sigil-no-identify-ncx-after

Message Three: sigil-no-ncx-before sigil-no-ncx-after

kevinhendricks commented 2 months ago

Thank you. These make good sense. I will make these changes after the upcoming fast follow-up bug fix release for version 2.3.1 which we hope to happen in a week or so. If we add them now, that will necessitate changes to translations that would delay the release while we wait for volunteers to handle them.

kevinhendricks commented 2 months ago

BeckyEbook, there are conflicts with the late changes I made to improve missing NCX handling in ImportEPUB.cpp and this PR. Would you please rebase your message changes from this PR on the released 2.3.1 source, so I can merge it without any conflicts.

Thanks!

kevinhendricks commented 2 months ago

Thank you!