search

Sigma88 / Sigma-Replacements

Handles replacement of various KSP assets
13 stars 1 forks source link

Fixed two exceptions caused by Unity Upgrade #84

Closed linuxgurugamer closed 4 years ago

linuxgurugamer commented 4 years ago

Moved initialization of two Texture2D variables from the class variables being initialized into a new Awake() method. Full info in issue #83

linuxgurugamer commented 4 years ago

Note: I was unable to compile because of missing resources, but the syntax passed VS checks

Sigma88 commented 4 years ago

hi @linuxgurugamer,

thank you for taking the time, I looked at this PR and everything seems fine to me.

if you care about me merging this PR into my mod I have a couple of requests:

  1. could you please push against the "Development" branch
  2. could you remove the extra files included in the obj/ folders

if you don't care about the github statistics I can just apply the changes manually myself, but I thought I mentioned it in case you like having your name in the repository stats

thanks again for pointing this out

linuxgurugamer commented 4 years ago

I jus saw that some temporary files got uploaded. Redoing it now

linuxgurugamer commented 4 years ago

I'll pull down the develop branch and redo this

Sigma88 commented 4 years ago

I think you can just push that agains the development branch it should be the same as the master branch at this moment, however I need to do more development stuff on the mods so I would rather have the changes there