SigmaHQ / pySigma

Python library to parse and convert Sigma rules into queries (and whatever else you could imagine)
GNU Lesser General Public License v2.1
395 stars 101 forks source link

Class CompareOperators is private #264

Closed Res260 closed 1 month ago

Res260 commented 2 months ago

Hello, I was trying to do a condition on a CompareOperators object, but I cannot import it:

image

Since CompareOperators is inside the SigmaCompareExpression class, it is private and we cannot import it:

image

Is there a problem with putting it outside the class so we can import it?

thomaspatzke commented 2 months ago

This should be fine or you access it with SigmaCompareExpression.CompareOperators.<OP>.

thomaspatzke commented 1 month ago

Changed it! Because it's a breaking change and I plan to do some of them for pySigma 1.0 it will be released with 1.0.