search

Sigmmma / Blendkrieg

Halo Model importer and exporter for Blender.
GNU General Public License v3.0
11 stars 3 forks source link

Basic node import #19

Closed ShellyHerself closed 4 years ago

ShellyHerself commented 4 years ago

Doesn't support different shapes right now.

~~This should be all the basic functionality we need, but right now we're running issues with some bugs in the reclaimer library. I'd like to fix those and then test this all again. Once we can fix the bugs in those libraries we might as well move the mode to mod2 conversion function into reclaimer instead of mozzarilla too, so we don't need to include it in our code.~~

If you try this, and you see the nodes all jumbled up in a little mess, that's the bug in reclaimer's doing. I'll update this pull request once we've made progress on that.

ShellyHerself commented 4 years ago

The bug in reclaimer should be fixed once the pull request is accepted.

I consider this pull request final now.

ShellyHerself commented 4 years ago

That is, final if the conversion function isn't suddenly moved before we've handled this.

ShellyHerself commented 4 years ago

This should be ready for re-review now.

ShellyHerself commented 4 years ago

Supports setting scaling, sizes for nodes. By default imports at Blender's metric (meters) size. Supports .gbxmodel, .model, .jms files.

Mimickal commented 4 years ago

I know we don't have Blender mocks yet, but if we did, what automated tests would you write? Let's get that stuff written down somewhere (preferably an issue) so we don't forget to add test coverage for this stuff later.

ShellyHerself commented 4 years ago

@Mimickal I made issue #21 as a response to your last comment.

ShellyHerself commented 4 years ago

Addressed review comments