SigmundGranaas / forgero

Tool creation and customization mod for Minecraft
MIT License
48 stars 15 forks source link

Types are ignored after recent handler/multithreading updates #1080

Closed JorisDeBeer closed 3 weeks ago

JorisDeBeer commented 1 month ago

SOFT_MATERIAL is suddenly allowed in offensive slots causing tooltip and tool to bug out

SigmundGranaas commented 3 weeks ago

Hasn't this always been the case? The offensive material slots can accept any type of material. Or were you thinking of another slot?

JorisDeBeer commented 3 weeks ago

what

JorisDeBeer commented 3 weeks ago

image

Offensive material is very very ancient.

With all the new materials I made new types, with "upgrade materials" being almost everything

Except for the following image

As this fits under slot -> material and upgrade is also a child of material

JorisDeBeer commented 3 weeks ago

wait how long has this been "broken".

Ur not gonna tell me that "type" in the schematic slot does not even work right?

SigmundGranaas commented 3 weeks ago
{
        "category": [
          "UTILITY"
        ],
        "type": "SWORD_GUARD"
      }

The type decides which type of content can fit in the slot, and the category decides which attributes will be picked from item on the slot

JorisDeBeer commented 3 weeks ago

Yea so why do "soft materials" go into the upgrade_material slot while they are no child type of that?

SigmundGranaas commented 3 weeks ago

I have no idea. I thought they were a subtype of upgrade material. I'll go digging

SigmundGranaas commented 3 weeks ago

https://github.com/user-attachments/assets/c28d0e42-035b-474d-98e2-0738577fcf31

I can't put it in

SigmundGranaas commented 3 weeks ago

It looks like sword are still using the MATERIAL type though:

{
        "upgrade_type": "SMITHING",
        "category": [
          "OFFENSIVE"
        ],
        "description": "reinforcement",
        "type": "MATERIAL"
      },
JorisDeBeer commented 3 weeks ago

oh