Crash with `0.10.7-rc2`

SigmundGranaas / forgero

Tool creation and customization mod for Minecraft

MIT License

48 stars 15 forks source link

Crash with `0.10.7-rc2` #432

Closed Steveplays28 closed 1 year ago

Steveplays28 commented 1 year ago

Version info

Minecraft 1.19.2
Forgero 0.10.7-rc2-BETA-1.19.2
Quilt 0.18.1-beta.59
QSL 4.0.0-beta.27 (provides Fabric API 0.73.0)

Log

org.quiltmc.loader.impl.FormattedException: java.lang.NullPointerException: Cannot invoke "com.sigmundgranaas.forgero.core.type.TypeTree.find(com.sigmundgranaas.forgero.core.type.Type)" because "com.sigmundgranaas.forgero.core.ForgeroStateRegistry.TREE" is null

SigmundGranaas commented 1 year ago

I make quite a few calls the the typetree around the codebase which really should not happen. I guess this issue would fit well with rewriting the typetree functionality behind a better interface. Directly referencing it should happen through a service of some sorts to prevent nullpointers like this from happening.

SigmundGranaas commented 1 year ago

Issue comes from the fact that The Fuel time map is created before Forgero is initialized. I don't really know why this happends, but it means that Forgero won't support burning parts as fuel on Quilt.

Steveplays28 commented 1 year ago

Alrighty, thanks for fixing the issue though, even if you had to remove functionality.