SigmundGranaas / forgero

Tool creation and customization mod for Minecraft
MIT License
48 stars 15 forks source link

Our own arrows cant be given potion effects #932

Open JorisDeBeer opened 1 month ago

JorisDeBeer commented 1 month ago

I am not sure how we would implement this.

SigmundGranaas commented 1 month ago

Hold my json

SigmundGranaas commented 2 weeks ago

image

Fermented spider eye json:

    "features": [
      {
        "type": "minecraft:on_hit",
        "on_hit": {
          "type": "minecraft:status_effect",
          "target": "minecraft:targeted_entity",
          "effect": "minecraft:poison",
          "level": 1
        },
        "title": "Poison",
        "description": "Applies poison on hit"
      }
    ]

Mastercrafted arrow head json:

"slots": [
      {
        "category": [
          "OFFENSIVE"
        ],
        "description": "upgrade",
        "type": "UPGRADE_MATERIAL",
        "tier": 1
      }
    ]

image

https://github.com/user-attachments/assets/d6f476a2-f20a-4f6e-87ed-6b19f03f6257

JorisDeBeer commented 2 weeks ago

how does this scale with the arrows? Do they get alot heavier because of the added weight?

SigmundGranaas commented 2 weeks ago

We can adjust the upgrade weight, it's currently at 10.

JorisDeBeer commented 2 weeks ago

Shall I add this to the handler branch I was working on recently? This adds alot of the status effects from minecraft itself. So I will just add the upgrade slots on arrows on that too

SigmundGranaas commented 2 weeks ago

That would probably work well :+1: