SignHash / signhash-webapp

MIT License
3 stars 0 forks source link

Use signhash-contracts NPM package #28

Closed jksf closed 6 years ago

jksf commented 6 years ago

I'd like to migrate from using contracts as git dependency to NPM package recently published and awaiting approval in https://github.com/SignHash/signhash-contracts/pull/33

The changes may affect any parts related to testrpc and compiled contracts. @biern Is there something I have to watch out for? Some unobvious dependencies or assumptions?

biern commented 6 years ago

So the webapp depends on the contracts in the following way:

Since webapp has started using testrpc API extensively for the build process I've made an explicit dev dependency webapp -> ethereumjs-testrpc , so contracts testrpc version should be of no concern to the webapp. Actually I believe there's even no need to share the seed script with the app in it's current state.