search

SignHash / signhash-webapp

MIT License
3 stars 0 forks source link

Mock fetching signer proofs #5

Closed biern closed 6 years ago

biern commented 6 years ago
biern commented 6 years ago

@jstefanski I made a typo during bower install and it didn't got saved, it's fixed now. About time we integrate a CI to avoid such problems

jksf commented 6 years ago

I had a problem to calculate the hash from the app (it couldn't complete). Also, the build process reported warnings. I rebased to latest master to see whether it builds on CI.

jksf commented 6 years ago

It didn't help. I'm stuck with:

Filename: lock.png
Size: 4687 Bytes
Loading...
No signer

Web console reports:

bundle.js:37485 [WDS] Warnings while compiling.
warnings @ bundle.js:37485
sock.onmessage @ bundle.js:59178
EventTarget.dispatchEvent @ bundle.js:36191
(anonymous) @ bundle.js:56495
SockJS._transportMessage @ bundle.js:56493
EventEmitter.emit @ bundle.js:7659
WebSocketTransport.ws.onmessage @ bundle.js:57841
bundle.js:37491            Src   Lib   All
Warnings   0     0     0  
Errors     0     0     0  

warnings @ bundle.js:37491
sock.onmessage @ bundle.js:59178
EventTarget.dispatchEvent @ bundle.js:36191
(anonymous) @ bundle.js:56495
SockJS._transportMessage @ bundle.js:56493
EventEmitter.emit @ bundle.js:7659
WebSocketTransport.ws.onmessage @ bundle.js:57841
aee6780….worker.js:716 asmCrypto seems to be load from an insecure origin; this may cause to MitM-attack vulnerability. Consider using secure transport protocol.

Build process output:

bundle.js:37485 [WDS] Warnings while compiling.
warnings @ bundle.js:37485
sock.onmessage @ bundle.js:59178
EventTarget.dispatchEvent @ bundle.js:36191
(anonymous) @ bundle.js:56495
SockJS._transportMessage @ bundle.js:56493
EventEmitter.emit @ bundle.js:7659
WebSocketTransport.ws.onmessage @ bundle.js:57841
bundle.js:37491            Src   Lib   All
Warnings   0     0     0  
Errors     0     0     0  

warnings @ bundle.js:37491
sock.onmessage @ bundle.js:59178
EventTarget.dispatchEvent @ bundle.js:36191
(anonymous) @ bundle.js:56495
SockJS._transportMessage @ bundle.js:56493
EventEmitter.emit @ bundle.js:7659
WebSocketTransport.ws.onmessage @ bundle.js:57841
aee6780….worker.js:716 asmCrypto seems to be load from an insecure origin; this may cause to MitM-attack vulnerability. Consider using secure transport protocol.
biern commented 6 years ago

@jstefanski thanks for taking the effort to test it! Turns out, I broke it while refactoring last night. Since types where checking correctly I didn't test the UI 😪 We're going to need some kind of tests here. I don't know what type yet, probably some higher level ones since testing such a strongly typed code seems like a waste for most cases. I've added minimal tests of what was actually failing, it probably will change a lot soon. Also CI integration is still to come.