Signal-Cartel / EveScoutRescue

Web site and data tools for evescoutrescue.com, maintainer ThriceHappy.
https://evescoutrescue.com/home/
13 stars 10 forks source link

Enabling tending of cache when status is Upkeep Required #221

Closed Klensor closed 5 years ago

Klensor commented 5 years ago

Fix for this issue: https://github.com/Thricehappy/EveScoutRescue/issues/211

Not entirely sure I've understood the problem correctly, but it does seem that it might be desirable for someone to tend a cache (and so reset the timer) even if they don't have the correct supplies to restock it.

bikerunner commented 5 years ago

Not sure if this PR is necessary. Seems to work for me without the change:

I understand the issue as:

Issue requires to allow consecutive 'Upkeep required' actions and not the message that this is not possible.

@Thricehappy can you recheck this interpretation. @Klensor This PR may need a rework to match the issue.

bikerunner commented 5 years ago

This PR looks valid after one more review with time. It's possible to keep the cache alive without having supplies. This works well with the changed payout strategy.

Thricehappy commented 5 years ago

Change pushed to production.