search

Signal-Cartel / EveScoutRescue

Web site and data tools for evescoutrescue.com, maintainer ThriceHappy.
https://evescoutrescue.com/home/
13 stars 10 forks source link

Prototype rescue success mail creation #250

Closed Klensor closed 4 years ago

Klensor commented 4 years ago

So, the basic idea is you find a request with a status of "closed-esrc", and when you click on you get a new button which allows you to craft evemails for both the involved signaleers and the rescued party. In the fullness of time, we can perhaps post these forms to the web-based mail client - for now it is cut and paste!

Also, random fixes - please check and let me know if these are keepers or not:

Changes to search.php line 186 -> modified as the code on master does not work for me... not sure if this is a php version issue?

Changes to esrccoordadmin.php line 255-> modified as button does not seem to do anything except confuse the paging.... I've linked it back to the modal dialog which seemed sensible, but perhaps it works better/properly on production?

Thricehappy commented 4 years ago

Is this functionality limited to be accessed only by ESR Coordinators?

The search.php change you call out seems fine to me. As for the esrccoordadmin.php one, I would like for @chigaze to comment on that workflow.

Klensor commented 4 years ago

Is this functionality limited to be accessed only by ESR Coordinators?

The button should only show for coordinators. Not sure about direct page access - probably you can get to it if you know the URL - you do need to be logged in at least

chigaze commented 4 years ago

I think I understand. If I read the code correctly then you’ve taken the “Update” button on the ESR Admin tab and modified it so rather than do nothing useful (aka broken) it will now allow actual updating of the SAR request...? If so then that is good.

Thricehappy commented 4 years ago

Please let me know when change requests are complete and this is ready to merge and push to dev for testing.

bikerunner commented 4 years ago

Changes look ok for me. I did not run a e2e test for the feature.