search

Signal-Cartel / EveScoutRescue

Web site and data tools for evescoutrescue.com, maintainer ThriceHappy.
https://evescoutrescue.com/home/
13 stars 10 forks source link

SAR Locate Payout Shows 0 ISK for the Locator in Firefox #320

Closed chigaze closed 3 years ago

chigaze commented 3 years ago
Screen Shot 2020-08-12 at 2 22 57 PM
Thricehappy commented 3 years ago

Is this Firefox-only or broken in Chrome, too?

Thricehappy commented 3 years ago

This was being caused by the check to see whether a given pilot is an "ESR Coordinator." Those who are, receive 0 payout. In some cases, the check was returning the status of the logged-in user instead of the requested user. Firefox may handle session variables slightly differently than Chrome, which was causing the discrepancy between results based on browser.

Tested and confirmed working correctly on both Chrome and Firefox now. No other browser tested, but the fix I made to Users->isSARCoordinator() should prevent this from occurring, regardless of context.

chigaze commented 3 years ago

The manager group had been discussing eliminating the coordinator exclusion as it does not make as much sense anymore. The reality is most of our advantage we've handed to the Operators by feeding them chains. Any future exclusions could be handled in the opt-out system you put together.

Thricehappy commented 3 years ago

If you need the current exclusion modified or removed, please open a new issue for that. I will be closing this one out shortly. Thanks!