search

Signal-Cartel / EveScoutRescue

Web site and data tools for evescoutrescue.com, maintainer ThriceHappy.
https://evescoutrescue.com/home/
13 stars 10 forks source link

Data errors on ESR Admin - Medals - SAR #333

Closed CCrinkle closed 3 years ago

CCrinkle commented 3 years ago

Under the above section, pilots who have left the corp a long time ago ( a year or more ) are shown as qualifying for SAR Medals in the last week . image

chigaze commented 3 years ago

This appears to be because I fixed a large number of old SARs where there was no Locator and/or Rescue Pilot listed. Related to the issue I mentioned in SC Engineering but forgot to add to github. :)

"while changing the locator and or rescue pilots on a closed SAR does not cause them to reappear in the payouts window it does still change the rescue date shown. This showed up in my stats run when I first thought we were having a huge August for SARS until I figured out the 30 SARs I fixed for rescue pilots and locators were showing up for today."

chigaze commented 3 years ago

With the medals I think it's not so much an issue as we have a number of pilots who should have got medals a couple years ago but didn't. For the most part they've all left corp I think. However they're all sorting to the top of the list as the "last action" got updated when I fixed the old entries.

Thricehappy commented 3 years ago

How often will it be that you go in and update old SARs with new rescue pilots? If this last round was mostly a one-time thing, than I think we should just leave #333 alone and let those updated records slowly filter out of the medals listing. There is only date to check for awarding medals to recue pilots, the date of when they were added to the rescue. This is only an issue for medals when they are added way after the fact, as in this case. I can go in and change dates on all of these you updated recently, if needed, although it will be a bit painstaking to find them all. Let me know what you all think.

Thricehappy commented 3 years ago

After further convo with Igaze, we will not fix this. It's a one-time issue, we hope.