SignalK / SensESP

Universal Signal K sensor framework for the ESP32 platform
https://signalk.org/SensESP/
Apache License 2.0
151 stars 81 forks source link

Remove "standard sensors" #438

Closed mairas closed 2 years ago

mairas commented 2 years ago

(Again, this PR also includes commits of PRs #435 and #436. Once the previous PRs are in, I'll update this one to get rid of the extra cruft.)

A second attempt; the first one was against the master branch which would've been BAD.

Here, the so called "standard sensors" are temporarily removed, to be re-added later. While their functionality is arguably useful for many people (and therefore, they shouldn't be removed for good), I had issues with the naming - I don't think they should be enabled by default, and "standard" in general leads me to think of things like AnalogInput or DigitalInput sensors. Also, I would like to improve on the interface. Bitfields and enumerations are IMO a bit awkward in defining functionality; regular method calls should be preferred.

Arguably, I should've made the new implementation right away instead of first removing the code, but since forthcoming PRs manipulate SensESPApp and SensESPAppBuilder quite heavily, it'd be quite difficult for me to refactor them around the changes. Sorry about that.