search

SignalK / SensESP

Universal Signal K sensor framework for the ESP32 platform
https://signalk.org/SensESP/
Apache License 2.0
151 stars 81 forks source link

Startable #440

Closed mairas closed 2 years ago

mairas commented 2 years ago

Enable class is renamed to Enableable. Yes, that is clunky, but I'd like to free the Enable class name for a transform.

Enableable priorities are fixed, and many of the essential classes now inherit from Enableable, removing the need to explicitly enable them. That helps a lot with future refactoring.

JohnySeven commented 2 years ago

What about name it Startup ? As all Enable are enabled during startup?

mairas commented 2 years ago

What about name it Startup ? As all Enable are enabled during startup?

How about Startable? The implemented method would be start()?

JohnySeven commented 2 years ago

Yes, Startable is good!

mairas commented 2 years ago

Renamed from original Enableable to Startable (and all methods likewise). This was a somewhat sweeping change and I made it as an additional PR instead of trying to inject the changes in every single commit of this PR. As a result, the chain of commits isn't quite optimal. But the end result is still that Enable was renamed to Startable.