Closed JohnySeven closed 2 years ago
The new features and changes are pretty great, and I can't wait to have them in SensESP!
In the PR description you listed five different unrelated new features or changes. To give me a fighting chance of reviewing the PR contents, would it be too much to ask if you re-submitted all those list items as five individual PRs? It is just so much easier to go through PRs that are about one single topic.
Also, please verify that the variable and class naming conforms to the Google C++ Style Guide and reformat the files.
Recapping an offline discussion: the PR will be reviewed without breaking it up.
Before I start the review, please double-check that variable naming in the C++ code conforms to the Google C++ Style Guide. Also, reformat the files and clean up the Git commits.
Thanks! Will do and let you know!
I'm currently unable to finish this PR due less free time - will do it later this month maybe.
So this is my 2nd pull request with few enhancements in WebUI area.
This PR add new features and enhances few things in WebUI:
Status page was little messy so after talk with @mairas we're introducing UIOutput supports Groups! There few default groups or you can create your own. Here is example:
Configurable
classvirtual String get_config_description()
for returning configurable description that will be visible in configuration page.Screenshots:
Jan