Fix for ESP32 variants ADC width compile error

SignalK / SensESP

Universal Signal K sensor framework for the ESP32 platform

https://signalk.org/SensESP/

Apache License 2.0

146 stars 80 forks source link

Fix for ESP32 variants ADC width compile error #600

Closed CaptIgmu closed 2 years ago

CaptIgmu commented 2 years ago

After upgrading to v2.4.1 of SensESP and v4.2.0 of platformio/esspressif32 I could finally compile for my Adafruit QT Py ESP32-S2 with only 1 error: setting the ADC width. The ADCs have changed on the newer ESP32 variants, the S2 can have 13 bits of resolution. This fix should now cover the ESP32 and its variants. Hope you have a successful compile!

mairas commented 2 years ago

Thanks for the PR! Sorry for the small delay; I was travelling for the last week and didn't have my laptop with me.

The PR looks good. I don't have any ESP32-S2 boards at hand at the moment, so I'll have to take your word on it. I'm glad that support for that platform is improved, though!

Merging.