SignalK / SensESP

Universal Signal K sensor framework for the ESP32 platform
https://signalk.org/SensESP/
Apache License 2.0
146 stars 80 forks source link

Chain Counter Example uses DigitalInputChange() incorrectly #623

Open BjarneBitscrambler opened 1 year ago

BjarneBitscrambler commented 1 year ago

I noticed that the Chain Counter example uses the DigitalInputChange() method incorrectly. The method definition in https://github.com/SignalK/SensESP/blob/main/src/sensesp/sensors/digital_input.h has the argument list as being

DigitalInputChange(uint8_t pin, int pin_mode, int interrupt_type, String config_path = "")

whereas the usage in the example https://github.com/SignalK/SensESP/blob/main/examples/chain_counter.cpp is

auto* button_watcher = new DigitalInputChange( BUTTON_PIN, INPUT, read_delay, read_delay_config_path);

The error is that the example passes a read_delay value where the method expects an interrupt_type. Both values are ints, so the compiler doesn't notice the problem.