SignalK / freeboard-sk

Chartplotter implementation for Signal K servers
Apache License 2.0
35 stars 27 forks source link

OpenSeaMap overlay not working #94

Closed juswes closed 3 years ago

juswes commented 3 years ago

Really nice and simple to use software, great work you guys! But am I the only one who does not seem to get the OpenSeaMap overlay displayed on top of the map in Freeboard? For example, see this screenshot of an other Signal K Web app named Vesselpositions (also by the Signal K team).

Screenshot 2021-03-14 at 11 42 55

And here is that same map location in the Freeboard Web app (note the missing Open Sea Map items).

Screenshot 2021-03-14 at 11 45 48

I have the Open Sea Map overlay turned on and ordered as the top layer. Plus I should be on a correct zoom level to be able to view the Open Sea Map items right?

Screenshot 2021-03-14 at 11 46 07

Am I doing something wrong or missing something here? Also, it seems to me that the implementation of the OpenStreetMap / OpenSeaMap charting canvas in the Signal K Vesselpositions extension somehow works much smoother when zooming in and out, etc. Any idea why that is?

BTW. I'm really impressed at the whole Signal K setup of tools, really great work and would love to start contributing to this effort myself.

panaaj commented 3 years ago

You are not doing anything wrong, I have identified the bug and have prepared a patch.

As to your observation re difference in map display compared to Signal K Vesselpositions... Signal K Vesselpositions uses Leaflet as the underlying map rendering library and Freeboard uses OpenLayers so this most likely accounts for the differences.

juswes commented 3 years ago

Many thanks @panaaj!

And as a side note. The scroll / zoom performance issue has also gone away somehow. Scrolling and zooming is now buttery smooth again. Might had to with this same issue?

Anyway, again, thanks a lot!