Coolant Pressure has incorrect value.

pbegg commented 3 years ago

Pulling engine data from an MAN engine, runs through a maretron J1939-N2K converter, out puts N2K pgn 127489. My signalK data sources is showing coolant pressure to be 120000000, which I believe is wrong by a factor of 1000.

Looking at canboat/analyzer/pgn.h:

'Oil Pressure' and 'Coolant Pressure' both have units of hPA

Looking at n2k-signalk/pgns/127489.js

Oil Pressure has just 'kPa'
Coolant Pressure has 'kPa * 1000'

removing the conversion factor of 1000 in coolant pressure should fix the issue. What I am missing is where in the process between canboat and signalk does the unit change from hPa to kPa?

I can create a pull request for the coolant pressure conversion factor to be removed in n2k-signalk/pgns/127489.js if this is the correct fix?

tkurki commented 8 months ago

@sbender9 any thoughts?

sbender9 commented 8 months ago

Yeah. This sounds right. We should remove the * 1000

philbegg commented 5 months ago

What is the correct fix for this?

SignalK / n2k-signalk

Coolant Pressure has incorrect value. #206