search

SignalK / n2k-signalk

NMEA 2000 to Signal K transformer
Apache License 2.0
25 stars 29 forks source link

callsignVhf missing for 129794 and 129810 #237

Closed wellenvogel closed 1 month ago

wellenvogel commented 2 years ago

The decoder should set communication/callsignVhf from the mentioned PGNs. Otherwise AIS data from N2K will miss this information (although available in the bus data).

pa1pdr commented 1 month ago

Can I ask for merging this? I also need the callsignVHF to be populated in the SK delta's

sbender9 commented 1 month ago

please check the PR, I added a comment

wellenvogel commented 1 month ago

Unfortunately I currently do not have any idea about the signalK testing - so it's hard for me to add those tests.

pa1pdr commented 1 month ago

Andreas, if you go into the test directory, you'll find e.g. the 129794_ais_class_a_static_data.js file and add somewhere at line 81 the line 

tree.should.have.nested.property(
      'communication.callsignVhf',
      '3FJJ4'
    )

The 3FJJ4 is in the testdata in line 46. Since the expected IMO number in line 69 is wrong, the test will fail anyway, but that is not your issue..

Do something similar for 129810 and you're done. Thanks for your help!

wellenvogel commented 1 month ago

Thanks. Added the test for 129794. But currently there is no test for 129810 at all.