PGN 127503 & 127504 not included in pgns/index.js

SignalK / n2k-signalk

NMEA 2000 to Signal K transformer

Apache License 2.0

25 stars 29 forks source link

PGN 127503 & 127504 not included in pgns/index.js #251

Closed patg closed 1 year ago

patg commented 1 year ago

Ist there any reason why those PGNs are not included index.js ? The source code for the PGNs is present in the source tree (127503.js and 127504.js) and the data seems correct.

Reference: https://www.nmea.org/Assets/nmea-2000-corrigendum-1-2010-1.pdf

tkurki commented 1 year ago

They were added in 2df6f754b0b04b9721c37b37269b006b1e7cd971 but to me it looks they were just accidentally left out, because all other pgns here added via maretron.js.

@sbender9 comments?

sbender9 commented 1 year ago

Yeah, I think was a mistake. They should have been included (and tests)