search

SignalK / nmea0183-signalk

NMEA0183 to Signal K parser
Other
30 stars 48 forks source link

Initial work on XDR parser #228

Open fabdrol opened 2 years ago

fabdrol commented 2 years ago

This PR implements an initial implementation for an XDR parser that uses the definitions format from xdr-parser-plugin. The implementation is different however, as that plugin has several issues IMO (e.g. require statements within function bodies).

In order to finish this PR, it would make sense (to me) to internalise the dictionary of XDR sentences rather tha pulling it from xdr-parser-plugin, and expanding on the definitions in there. Also, it would make sense to make the expression dependent on the unit (RN I'm simply checking if the units match).

tkurki commented 2 years ago

Where would the user configure this? The nice thing about plugins is that configuration ui is essentially free.

Also are you aware of https://github.com/SignalK/nmea0183-signalk#custom-sentences ?

fabdrol commented 2 years ago

No, wasn't ware. But, this is a PR to expand the functionality of this parser, not just for users of Signal K server.

fabdrol commented 2 years ago

@tkurki thanks for review, I'll update. I'd like to ship with a slightly more complete set of defs if possible, so if you have any XDR data (that's not already in the repo of signalk-server), please let me know.