search

SignalK / signalk-derived-data

Generates deltas for values derived from signalk values
Apache License 2.0
18 stars 30 forks source link

Update eta.js - timeToGo added and in Seconds #126

Closed Techstyleuk closed 7 months ago

Techstyleuk commented 8 months ago

estimatedTimeOfArrival updated to have null instead of "--" in the case of it not having a value

timeToGo added as a value in Seconds, null when there is no value

See Forum post: https://forum.openmarine.net/showthread.php?tid=5017

Techstyleuk commented 8 months ago

@tkurki Thanks for the Feedback

I will make the changes and resubmit. I will change 'seconds' to 'var ttg' then use ttg from then on (in the else statement and as the value for ...timeToGo. I think the indenting will be sorted by the removal of 'hms'

tkurki commented 7 months ago

Still on this?

Techstyleuk commented 7 months ago

This PR should be replaced with PR#127. I am new to PR's and didn't really know how to make adjustments without resubmission

tkurki commented 7 months ago

FYI PRs are directly connected to the branch. Recreate the branch and force push it to Github and your PR will reflect the new state.