search

SignalK / signalk-derived-data

Generates deltas for values derived from signalk values
Apache License 2.0
18 stars 30 forks source link

fix: capture zero revolutions when calculating propslip #86

Closed chris0348 closed 2 years ago

chris0348 commented 3 years ago

fix: capture zero revolutions when calculating propslip. Before, propslip.js divided by zero when revolutions were zero.

joabakk commented 2 years ago

Good catch. But please do not mix with other fixes (directionTrue)

tkurki commented 2 years ago

I reimplemented this in #93 without the extra stuff and with a test, could you check that.

tkurki commented 2 years ago

Thanks #93 now merged.