Calculations for set and drift

SignalK / signalk-derived-data

Generates deltas for values derived from signalk values

Apache License 2.0

18 stars 30 forks source link

Calculations for set and drift #99

Closed davidsanner closed 2 years ago

sbender9 commented 2 years ago

I don't love that you moved things around. Makes it much harder to review.

Did you change anything with the existing calculations?

davidsanner commented 2 years ago

I'd be happy to submit a new/clean PR for courseOverGroundMagnetic calc with whatever group you think fits best. Do you think 'heading' group fit best for courseOverGroundMagnetic? I could also submit a separate PR for the set & drift calculations if that makes sense and delete this PR.

davidsanner commented 2 years ago

Submitted new PR #100 from clean master branch. Does not effect existing calculations.