SignalK / signalk-server

An implementation of a Signal K central server for boats.
http://signalk.org
Apache License 2.0
315 stars 154 forks source link

Global indicator that changes need a restart to take effect #1615

Open JacoKoster opened 1 year ago

JacoKoster commented 1 year ago

As mentioned in #1601 we would like a global overall notification that changes were made that need a server-restart.

This could also be used for a global notification that there are unconfigured plugins?

tkurki commented 1 year ago

Having unconfigured installed plugins is a normal case and an indicator would be noise, because the server installs some by default that may be inactive in the setup by design.

How about

Reworded the title just a little, as Notifications have a special meaning. That is actually another way to go about this: add a mechanism to display notifications in the admin UI and activate a notification, that will be visible in InstrumentPanel, WilhelmSK etc.

mpvader commented 1 year ago

For more notes on this:

1) there is a "Restart required" note on the service settings page, see first screenshot. It probably means to see that if and when you change settings, you'll need to restart. But to me it also looks like I already did something and need to restart (but I didn't do anything yet :) ).

2) After clicking save, there is an alert/popup. Perhaps there add the text ". Restart the server by [where to find that button]". See also second screenshot.

image

image

tkurki commented 5 months ago

Appstore now has an explicit mention of need to restart the server.

mpvader commented 3 months ago

One more thing on this:

when logging into a vanilla install of signal k server, it will force the user to make a login, and when done requires a reboot of the server. See below screenshot.

Not really nice from UX / onboarding perspective. Why not just do the restart? Or is it normally not possible to restart? (when running in Venus OS, it can just terminate itself and then it will always be restarted).

And more specifically to the Venus OS use case, and also further off topic of this issue, it would be nice for Signal K to be able to be protected using the Venus OS system wide username and password. For Node-RED flow editor we do the same; and perhaps good to know that we're nearing the beta testing phase of a project where we use that password also to protect gui-v2 and other web access.

image