feat: ws connection name replaced with description on Dashboard Connections activity

SignalK / signalk-server

An implementation of a Signal K central server for boats.

http://signalk.org

Apache License 2.0

298 stars 150 forks source link

feat: ws connection name replaced with description on Dashboard Connections activity #1705

Closed KEGustafsson closed 2 months ago

KEGustafsson commented 3 months ago

tedenda commented 3 months ago

Fixes #1146

Thanks!

tkurki commented 3 months ago

I think we should add this data to the connection information on the server, so that the ui would not need to fetch it separately. The security api also needs admin level access, if the server passes the data then that is not a problem for non admin users.

KEGustafsson commented 3 months ago

Non-admin use case was not considered, so this need redesign.

PR will be updated, when new approach is a bit more clear. This will need some investigations.

KEGustafsson commented 3 months ago

In addition to previous issue, there is noticeable performance degradation in slow networks, which makes this approach not usable. One more thing, which drives this PR back to drawing board.