SignalK / signalk-server

An implementation of a Signal K central server for boats.
http://signalk.org
Apache License 2.0
307 stars 152 forks source link

fix: don't subscribe to notifications in sk connections #1736

Closed tkurki closed 4 months ago

tkurki commented 4 months ago

@signalk/client subscribes by default to notifications.*. This is confusing in the first place if the user enters an explicit subscription and gets more than they subscribed.

Furthermore this wreaks havoc if you have two interconnected SK servers. Their explicit subscriptions will not create a loop if they don't touch the same paths, but the default notifications subscription will if there is even one active notification.