search

SignalK / signalk-to-nmea0183

Signal K Node server plugin to convert Signal K to NMEA 0183
Apache License 2.0
13 stars 28 forks source link

Add missing brackets in the example #34

Closed FredericGuilbault closed 5 years ago

tkurki commented 5 years ago

That configuration snippet is valid (well, as valid as a snippet is) but you have pipedProvider that consists of a single serialport provider, meaning that there is nothing that converts the serialport input to Signal K, which 99.9% of the time is incorrect.

The README dates from the time with SK server having no admin ui to speak of and inputs were configured by editing settings files.

Now we have the admin ui, so a better example here would be a screen shot of the relevant part of it. Care to make one?

FredericGuilbault commented 5 years ago

Ah oui, I get it now. I must say it's confusing ...to the point I tought it was an error lol.

But then, I have read https://github.com/SignalK/signalk-to-nmea0183/issues/11 And as I understand, this snippet does not reflect intended use of signalk-to-nmea. This plugin emit tcp on port 10110. But the snippet seem to be about producing a fake serial device/port in /dev/. There is an other plugin for serial devices If I remember.

Prior to updating the README I just want to make sure about that. Then ill make a proposal with an updated screen shot.

tkurki commented 5 years ago

The configuration snippet is about the case where you want to output the sentences to a serial connection. The plugin itself only output events, that are used by default by tcp connection on port 10110. If you want serial output you need to configure the serial to handle the event as well.

FredericGuilbault commented 5 years ago

Im still a bit confused, so Im not sure if I got this right. Tell me if something need to be changed. IDC making an other revision.

tkurki commented 5 years ago

I updated the readme in 001c27971e1e5d7579f1758ae5df7c3e5d435b41.