SignalK / signalk-to-nmea0183

Signal K Node server plugin to convert Signal K to NMEA 0183
Apache License 2.0
13 stars 28 forks source link

Request: Sentence format adjustments #67

Open KonradStreit opened 3 years ago

KonradStreit commented 3 years ago

I am trying to display data from the SignalK server running on a pi on my old stowe Dataline instruments, with Dataline being an early take on NMEA0183 as I understand. They are receiving the data, however are expecting a slightly different format, i.e. the VHW sentence from this plugin outputs XXX.X, M for the magnetic heading while the instruments expect XXX, M without a decimal. At the moment I am getting values on the screen, but apart from the STW they are alll wrong and some of them going all over the place each time the display is updated. Is there a way I am not aware of to adjust the format? Otherwise it would be a great feature. I would love to help as much as I can but have no experience at all with javascript.

KonradStreit commented 3 years ago

I believe I have just found out how I can do it for my installation by changing the .toFixed(x) values according to the stowe manual in each sentence's .js file, but this might be helpful for other people as well. Not sure how complicated these additional variable would be to implement, I am thinking maybe similar input fields like the throttle per sentence?

tkurki commented 3 years ago

I think an option to round all angles to the nearest degree would make sense. Want to give it a try? Add the option to the schema, and then it needs to be passed to the converter and handled there.

KonradStreit commented 3 years ago

I am trying to understand how this whole thing works, as mentioned, I have not done any javascript so far. So right now I am not even sure how I would test any changes I make, is there any guide you could point me to that explains how I could set up my SignalK-Server to install a plugin that I have changed locally? Or at least how to test wether the code I have written works on its own? So far I have only used the GUI on my openplotter setup which lets me install plugins from the appstore.