fix: 'value' made a required property for anything using commonValueFields in schema

[bkp7]

Ref issue #423.

This changes the schema in a non backwards compatible way, so will bump the version to 1.1.x. Do you want to create a separate branch for changes which will bump the schema version? I will have more to come next week as I'm intending to review the schema once I've completed the testing and document refactoring.

[rob42]

427

[fabdrol]

@bkp7 @tkurki @rob42 how should we handle this - as it is a breaking change? My feeling is:

• Use master as the development line for any non-breaking work, i.e. on the current major and minor version level
• Set up a new branch (development?) in which we can merge breaking stuff like this (or perhaps a branch name like 1.1.x - although that may backfire if for whatever reason we want to delay this until 1.2.x).

Only downside may be that such a branch needs rebasing on master every now and then. Thoughts?

[bkp7]

I have been working on changes required to lose the TV4 dependency, and it would be very time consuming to do that work and retain bugs like this and #427 (with a view to subsequently fixing the bugs). It will be much easier to fix the bugs as we work through the changes required for TV4. There are some areas where there are a fair number of anomalies.

I propose a branch 'schema clean up' or similar with the purpose of dealing with these issues and the TV4 dependency. From my work so far I believe the clean up may require going to version 2. I am happy to get this work done, but it would be easier to have a specific branch for the purpose so everyone can comment/contribute if required.

[fabdrol]

@bkp7 that makes sense, here you go: https://github.com/SignalK/specification/tree/schema-cleanup