Closed bkp7 closed 6 years ago
Please could I have confirmation that this workflow is what is expected.
At the time of creating this PR the schema-cleanup branch was 2 behind the master (e26be72 and 5291036).
715d9dd was a PR against the master which had not been merged.
Then there's the deletion of gaugeType 21438f0 which is what this PR is really about.
Q: should I have rebased first and created a separate PR to this branch for the 1st 2 commits? I don't have permission to commit to this branch so the rebasing PR would need to be committed by others.
Q: should commit 715d9dd be included in this PR? What happens if it is never merged into the master?
Thanks
@bkp7 we should probably keep an eye on schema-cleanup
, and make sure that it gets rebased on master every now and again. Here's what I propose we do:
gaugeType
into schema cleanupschema-cleanup
, that it needs to be merged onto master at some pointSince cleanup is one of those tasks that one can do forever, let's make a todo list of things that really badly need doing. That'll be the scope for the schema-cleanup
branch and once that list is done, we rebase it on master and create a PR for the branch. Further cleanup can be done in a new branch.
Q: do you have a list of things you feel should be in Schema Cleanup?
Remove gauge type from meta.
closes #409