SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

clarify: Wind #520

Open Dirk-- opened 5 years ago

Dirk-- commented 5 years ago

TWD:

AWD:

TWS:

joabakk commented 5 years ago

It might be better to fork and make a pull request, so we can see what you are proposing in code. Is it the descriptions you are lproposing to change?

Dirk-- commented 5 years ago

reworked things, here is my proposal: environment.wind:

My (limited) knowledge is based upon https://opencpn.org/wiki/dokuwiki/doku.php?id=opencpn:opencpn_user_manual:terminology

joabakk commented 5 years ago

As this would be a breaking change, and any clients using the existing schema would have to be re-written, I would suggest refining the descriptions instead of the path names. Granted, the current path names can lead to confusion, but that can be resolved more easily by the descriptions. I would propose that you make a pull request with the additions and the description changes you propose

sbender9 commented 5 years ago

You're changes make sense and too bad you weren't here before we finalized 1.0.

But as @joabakk said, we can't make breaking changes in the 1.x spec. It could be considered for 2.0, but that's probably a long way off.

tkurki commented 5 years ago

The different wind related figures seem to cause endless debates. Honing the descriptions would be the way to go here - no matter how you name them, they won't be crystal clear to everybody.

Plus the backwards compatibility already mentioned.