search

SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

Fix: reducedState as object #526

Closed joabakk closed 5 years ago

joabakk commented 5 years ago

fixes #525

tkurki commented 5 years ago

It would be great to have some tests that excercise this feature.

joabakk commented 5 years ago

I would be happy to, when time permits. Rather surprisingly, the test never failed. Any idea how to make a test that is more general than just checking if this specific one is an object?

tkurki commented 5 years ago

Which test never failed?

joabakk commented 5 years ago

This one: https://github.com/SignalK/specification/blob/master/test/data/vessel-valid/sails-sample.json I'm just trying to figure out what to test for. First of all, should all paths in the tree have a description and a type? I don't want the tests to be too specific for one PR

tkurki commented 5 years ago

See https://github.com/heiamoss/specification/pull/1 for adding a test that detects if the schema detects invalid reduced state.

joabakk commented 5 years ago

Thanks @tkurki you did it for me again. That was not my intention. Now how do we get travis to look at this again?