search

SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

Fix PUT default context and warn about paths #536

Closed rob42 closed 5 years ago

rob42 commented 5 years ago

Fix PUT default context and warn about paths. The default context of vessels.self made it very difficult to distinguish between resources',sources`, and other root level branches we may grow. While it can be done at the server end it creates complexity and is error prone.

The default is removed, always use full path

rob42 commented 5 years ago

Oh damn - sucked in the unmerged swagger changes....

sbender9 commented 5 years ago

I think this PR was merged prematurely. I disagree with the removal of the default. And it also contains unrelated changes. I assumed you were going to remove those commits since you clearly knew they were in there.

rob42 commented 5 years ago

Just realised the initial openapi.json commit was there too. I thought it was just the update, which was simply an improvement. The removal of the default produced no comments, so i merged it. I will revert the pull and create a new one