SignalK / specification

Signal K is a JSON-based format for storing and sharing marine data from different sources (e.g. nmea 0183, 2000, seatalk, etc)
Other
91 stars 68 forks source link

fix: choice of the value of the notification state #545

Closed cmotelet closed 5 years ago

cmotelet commented 5 years ago

The purpose of this PR is to clarify the possible values for the states in notifications vs the states in zones.

The file gitbook-docs\data_model_metadata.md#alarm-management was already updated in the documentation.

Please comment to find the best compromise.

tkurki commented 5 years ago

Hmm. Zones and notifications are connected in the spec: https://signalk.org/specification/1.3.0/doc/notifications.html#expected-implementation-behaviour

If we have zones that define normal and nominal zones they are treated like the more serious notifications: when the value is in that zone the notification is set. I don't think we have anywhere specified that normal and nominal are special cases and should not set notifications values.

So I don't think anything needs to be changed in the spec.

cmotelet commented 5 years ago

cancelled following tkurki's explanations